Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages*.clang_manpages: drop the sphinx find_package patch #218640

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

rrbutani
Copy link
Contributor

This is a backport of f8cbbdd.

LLVM versions >= 5.0.0 already look for sphinx when LLVM_ENABLE_SPHINX is enabled: llvm/llvm-project@ea139ec


h/t @alyssais for pointing out this should be backported

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is a backport of f8cbbdd.

LLVM versions >= 5.0.0 already look for sphinx when `LLVM_ENABLE_SPHINX`
is enabled: llvm/llvm-project@ea139ec
@rrbutani
Copy link
Contributor Author

@ofborg build llvmPackages_5.clang-manpages llvmPackages_6.clang-manpages llvmPackages_7.clang-manpages llvmPackages_8.clang-manpages llvmPackages_9.clang-manpages llvmPackages_10.clang-manpages llvmPackages_11.clang-manpages llvmPackages_12.clang-manpages llvmPackages_13.clang-manpages llvmPackages_14.clang-manpages llvmPackages_git.clang-manpages

@rrbutani rrbutani requested a review from alyssais February 27, 2023 16:31
@alyssais
Copy link
Member

OfBorg timed out. Let's try again.

@ofborg eval

@alyssais
Copy link
Member

Going to try the OfBorg build one more time because it looks like we hit a Nix race condition in the aarch64-darwin build:

@ofborg build llvmPackages_5.clang-manpages, llvmPackages_6.clang-manpages, llvmPackages_7.clang-manpages, llvmPackages_8.clang-manpages, llvmPackages_9.clang-manpages, llvmPackages_10.clang-manpages, llvmPackages_11.clang-manpages, llvmPackages_12.clang-manpages, llvmPackages_13.clang-manpages, llvmPackages_14.clang-manpages, llvmPackages_git.clang-manpages

@alyssais alyssais merged commit b06ac37 into NixOS:staging Mar 2, 2023
@rrbutani rrbutani deleted the fix/drop-clang-docs-sphinx-patch branch March 8, 2023 03:23
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants